From: Zacharie DUBRULLE <dubrullezacharie@gmail.com>
Date: Thu, 18 May 2023 11:40:32 +0000 (+0000)
Subject: dnd: Don't leak a signal connection
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~337^2~2^2~69
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=d7542db38c4a2916c61fabee55faf10fcb287764;p=gnome-shell.git

dnd: Don't leak a signal connection

The handler is currently leaked when a drag monitor stops a
motion event.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2770>
---

diff --git a/js/ui/dnd.js b/js/ui/dnd.js
index c9bce01f5..53b4fde6c 100644
--- a/js/ui/dnd.js
+++ b/js/ui/dnd.js
@@ -590,6 +590,7 @@ var _Draggable = class _Draggable extends Signals.EventEmitter {
                 let result = motionFunc(dragEvent);
                 if (result != DragMotionResult.CONTINUE) {
                     global.display.set_cursor(DRAG_CURSOR_MAP[result]);
+                    dragEvent.targetActor.disconnect(targetActorDestroyHandlerId);
                     return GLib.SOURCE_REMOVE;
                 }
             }